Skip to content

Upgrade to the latest openssl#75

Open
alex wants to merge 1 commit into
Antti:masterfrom
alex:upgrade-openssl
Open

Upgrade to the latest openssl#75
alex wants to merge 1 commit into
Antti:masterfrom
alex:upgrade-openssl

Conversation

@alex

@alex alex commented Jan 5, 2019

Copy link
Copy Markdown

The version of openssl that was previously used had numerous security issues, and did not support the latest versions of the upstream openssl package.

I wasn't sure what to do about the impl Clone on connection, there doesn't appear to be a way to get the current behavior with SslStream in the latest version of openssl.

The version of openssl that was previously used had numerous security issues, and did not support the latest versions of the upstream openssl package.
@Shnatsel

Shnatsel commented Jan 5, 2019

Copy link
Copy Markdown

Relevant to #58

@dizda

dizda commented Jan 15, 2019

Copy link
Copy Markdown

LGTM 👍

@Antti

Antti commented Jan 24, 2019

Copy link
Copy Markdown
Owner

This doesn't really upgrade to the latest openssl, as adding panic makes it TLS mode completely non-functional.
I removed tls feature from the list of default features, this should make it easier to use this crate when the tls (openssl) feature is not required.

@alex

alex commented Jan 24, 2019

Copy link
Copy Markdown
Author

Hmm, unfortunately I don't believe it's possible to emulate the Clone API with a recent OpenSSL, except perhaps by making it an Rc (or maybe Arc or Mutex + Arc). Do you have an opinion on how to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants