Fixed a problem that prevented multiple AnyPyTools instances#131
Merged
Fixed a problem that prevented multiple AnyPyTools instances#131
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug where multiple AnyPyProcess instances running in the same process would interfere with each other. Previously, when one instance finished its start_macro() call, it would terminate all running AnyBody processes, including those belonging to other instances.
Key Changes:
- Each
AnyPyProcessinstance now maintains its own_local_subprocess_containerinstead of sharing a global container - Added a
__del__method to ensure proper cleanup of instance-specific subprocesses - Added support for tuple input in
start_macro()macrolist parameter - Added debug capability to use Python's standard
Popeninstead ofJobPopenon Windows via environment variable
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pixi.toml | Version bump to 1.20.0 |
| anypytools/init.py | Version bump to 1.20.0 |
| CHANGELOG.md | Added release notes for v1.20.0 describing the fix |
| anypytools/abcutils.py | Core fix: added per-instance subprocess containers, __del__ method, tuple support, and debug mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a problem that prevented multiple AnyPyTools instances from running simultaneously in the same process. Previously, other running AnyBody instances were shut down when the first
AnyPyProcess.start_macro()call finished.