Conversation
bkje14
left a comment
bkje14
left a comment
There was a problem hiding this comment.
I can help you make the PR for updating the muscle parameter files - that I think we should do before merging this PR.
|
|
||
| #if BM_ARM_DELTOID_WRAPPING == OFF | ||
| AnyFolder deltoideus_scapular_part_1 = | ||
| AnyFolder DeltoideusScapular1 = |
There was a problem hiding this comment.
This whole file is generated from a template so we need to update the data to the template - I can show you where it is :)
| #if BM_ARM_DELTOID_WRAPPING == OFF | ||
| ///////////////////////////////////////////////////// | ||
| // deltoideus_scapular_part_2 (1 element ) // | ||
| // DeltoideusScapular2 (1 element ) // |
There was a problem hiding this comment.
This whole file is generated from a template so we need to update the data to the template - I can show you where it is :)
The templates and data is in the same repo as you did the BikeModel updates
| AnyFolder QuadratusLumborumR12IC_1 = | ||
| { | ||
| AnyString Muscle = "QLC12Lat_CILat"; ///< Descriptive name for the muscle, e.g. for plotting | ||
| AnyString Muscle = "QuadratusLumborumR12Lat_CILat"; ///< Descriptive name for the muscle, e.g. for plotting |
There was a problem hiding this comment.
@JacobAdamsen can you help determine if "Lat" is most often written out as "Lateral" in the code ?
| AnyFolder QuadratusLumborumR12IC_2 = | ||
| { | ||
| AnyString Muscle = "QLC12InterMedian_CILat"; ///< Descriptive name for the muscle, e.g. for plotting | ||
| AnyString Muscle = "QuadratusLumborumR12InterMedian_CILat"; ///< Descriptive name for the muscle, e.g. for plotting |
There was a problem hiding this comment.
This file is also auto generated from data
Further work of the muscle renaming done in PR #97 and #96.
Renaming muscles to follow the same templates/conventions as in the previous 2 PR's.
General review of muscles that still needs to be renamed.