fix: update threshold_config set_config calls#26
Conversation
|
Thanks for the cleanup @Errordog2! Quick heads-up before I can merge this: per our contribution guidelines, every PR needs to be linked to an approved tracking issue so maintainers have the context to triage. I don't see a |
|
Hi @Errordog2, thanks for the PR. The closest matching issue (#3) is assigned to @aliyuHabibu, so under our author=assignee policy we can't merge this from your handle. Also looks like #56 by @Joeloo1 already addresses the same threshold_config set_config concern. Could you coordinate on the issue, or close this in favor of the existing PR? 🙏 |
Summary
threshold_config.rsto use the currentset_config(caller, severity, threshold_minutes, penalty_per_minute, reward_base)APISLAConfigimportValidation
git diff --checkpasses locallycargo test -p apexchainx_calculator threshold_config --no-default-featurescould not complete in this Windows environment because the MSVC linkerlink.exeis not installed