ci: add WASM no-std compliance check to pipeline#65
Merged
Icahbod merged 1 commit intoJun 24, 2026
Conversation
Adds a dedicated cargo check --target wasm32-unknown-unknown --lib step to the client-checks job so any accidental std import surfaces as a compile error before deployment. The wasm32 target is already installed in the prior toolchain step, and the existing no_std declaration in lib.rs ensures the check passes on the current codebase. Closes ApexChainx#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #12 by adding a dedicated
cargo check --target wasm32-unknown-unknown --libstep to theclient-checksjob in.github/workflows/ci.yml.Problem
README.mddocuments thecargo check --target wasm32-unknown-unknown --libno-std compliance check, but it was not exercised in CI. A strayuse std::...orprintln!would compile fine undercargo teston the host (which re-enablesstdvia the test harness) yet fail at deployment time.Fix
Add a single step right after the existing toolchain install (which already pulls the
wasm32-unknown-unknowntarget):Pattern mirrors the existing
Cargo checkstep (host) so logs are consistent on failure.Acceptance criteria from #12
wasm32no-std check.on: pushandpull_request).wasm32target (already installed by the prior toolchain step in theclient-checksjob).stdimport is introduced.lib.rsdeclares#![no_std]and a project-wide grep finds nouse std::references.Closes #12