Centralized dependencies#66
Open
gloskull wants to merge 2 commits into
Open
Conversation
Centralized common package metadata (edition, license, repository) and the soroban-sdk dependency in the root Cargo.toml workspace configuration. Updated apexchainx_calculator to inherit these properties. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…9613984904 infra: centralize shared dependencies in [workspace.dependencies]
Author
|
Done with this issue. |
Contributor
|
@gloskull resolve conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Centralizes shared package metadata and the
soroban-sdkdependency in the rootCargo.tomlto eliminate duplication, prevent version drift across workspace members, and simplify the addition and maintenance of future crates.Type of Change
Related Issues
Fixes #41
Changes Made
[workspace.package]to the rootCargo.tomlwith sharededition,license, andrepositorymetadata.[workspace.dependencies]to the rootCargo.tomlwithsoroban-sdk = "21.1.0"for centralized dependency management.apexchainx_calculator/Cargo.tomlto inheritedition,license, andrepositoryfrom the workspace.apexchainx_calculator/Cargo.tomlto inheritsoroban-sdkfrom the workspace while preserving crate-specific feature flags.Testing
Describe the testing performed to validate these changes:
Manual verification included:
apexchainx_calculatorcorrectly inherits workspace metadata and the sharedsoroban-sdkdependency while retaining its required feature flags.Checklist
My code follows the project's style guidelines
I have performed a self-review of my own code
I have commented complex logic (where applicable)
I have updated relevant documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
My changes do not introduce new warnings
Closes #41