Open
Conversation
Collaborator
alzinchenko
commented
Jan 19, 2022
alzinchenko
commented
- moved the business logic from the SmcApi controller to the service;
- used StringUtils instead of Strings;
- renamed the ComplexKey class to ThreeValuesKey;
- added Range interface and implementation to represent boundaries of something;
- added query objects (ContractQuery, ContractEventQuery) for filtering smart-contracts and contract events;
- moved Sort and Range files to utils module;
…pollo into fix/smc-api-refactoring
…pollo into fix/smc-api-refactoring
…boundaries of something; added query objects (ContractQuery, ContractEventQuery) for filtering smart-contracts and contract events; moved Sort and Range files to utils module;
…into fix/smc-api-refactoring
…into fix/smc-api-refactoring
yuriy-ln
reviewed
Jan 20, 2022
...core/src/main/java/com/apollocurrency/aplwallet/apl/core/rest/v2/impl/SmcApiServiceImpl.java
Show resolved
Hide resolved
yuriy-ln
approved these changes
Jan 20, 2022
Collaborator
AndrewBoyarsky
left a comment
AndrewBoyarsky
left a comment
There was a problem hiding this comment.
Tests required for SmcContractServiceImpl new methods
.../main/java/com/apollocurrency/aplwallet/apl/core/dao/state/smc/SmcContractEventLogTable.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/apollocurrency/aplwallet/apl/core/dao/state/smc/SmcContractTable.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/com/apollocurrency/aplwallet/apl/core/service/state/smc/ContractQuery.java
Outdated
Show resolved
Hide resolved
...om/apollocurrency/aplwallet/apl/core/service/state/smc/impl/SmcContractEventServiceImpl.java
Outdated
Show resolved
Hide resolved
.../com/apollocurrency/aplwallet/apl/core/service/state/smc/impl/SmcContractRepositoryImpl.java
Outdated
Show resolved
Hide resolved
.../com/apollocurrency/aplwallet/apl/core/service/state/smc/impl/SmcContractRepositoryImpl.java
Outdated
Show resolved
Hide resolved
apl-utils/src/main/java/com/apollocurrency/aplwallet/apl/util/api/Sort.java
Outdated
Show resolved
Hide resolved
apl-utils/src/main/java/com/apollocurrency/aplwallet/apl/util/api/Sort.java
Outdated
Show resolved
Hide resolved
.../main/java/com/apollocurrency/aplwallet/apl/core/dao/state/smc/SmcContractEventLogTable.java
Outdated
Show resolved
Hide resolved
apl-utils/src/main/java/com/apollocurrency/aplwallet/apl/util/api/PositiveRange.java
Outdated
Show resolved
Hide resolved
apl-utils/src/main/java/com/apollocurrency/aplwallet/apl/util/api/PositiveRange.java
Outdated
Show resolved
Hide resolved
apl-utils/src/main/java/com/apollocurrency/aplwallet/apl/util/api/Range.java
Outdated
Show resolved
Hide resolved
Collaborator
|
@alzinchenko Still required unit tests for SmcContractService new methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.