[WIP] Upgrade to the latest version of sae_vis#58
Open
jordansauce wants to merge 7 commits intomainfrom
Open
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See issue #54: Currently our feature dashboards rely on an old commit of Callum McDougall's sae_vis library. Specifically, callummcdougall/sae_vis@b28a0f7.
This PR will make our code compatible with the latest version of sae_vis (0.2), which was significantly restructured in March 2024. The recent changes include:
parse_feature_data()andparse_prompt_data()are now added to sae_vis, so we can remove them from our codebase - see Added SAE class agnostic functions callummcdougall/sae_vis#17No more major restructures of sae_vis are planned from now (callummcdougall/sae_vis#15 (comment)) so this is a good time to upgrade.
However it also seems much slower to generate prompt-centric dashboards now (either that or I'm doing something wrong), so this shouldn't be merged until that's fixed.