Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now uses a tempfile directory (
/tmp/random_hash/) instead of writing to/tmp/directly. This tmpdir is then immediately cleaned up by the context manager.Motivation and Context
This is because I was getting permission issues writing to the tmpfile directory on the cluster.
A big disadvantage is that this no longer caches the files anywhere. Probably it would be best to support a more permanant cache in some form (in which case this PR can be superseeded).
How Has This Been Tested?
I have successfully used the code.
Does this PR introduce a breaking change?
breaks the current caching behavior