Skip to content

Fix fan widget speeds #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ondras12345 wants to merge 1 commit into
base: dev
Choose a base branch
from
+10 −10
Open

Fix fan widget speeds #2607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions appdaemon/widgets/basefan/basefan.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,17 @@ function basefan(widget_id, url, skin, parameters)

function On1ButtonClick(self) {
args = self.parameters.post_service_speed;
args["speed"] = self.parameters.fields.low_speed;
args["percentage"] = self.parameters.fields.low_speed;
self.call_service(self, args);
}
function On2ButtonClick(self) {
args = self.parameters.post_service_speed;
args["speed"]= self.parameters.fields.medium_speed;
args["percentage"]= self.parameters.fields.medium_speed;
self.call_service(self, args);
}
function On3ButtonClick(self) {
args = self.parameters.post_service_speed;
args["speed"] = self.parameters.fields.high_speed;
args["percentage"] = self.parameters.fields.high_speed;
self.call_service(self, args);
}

Expand All @@ -112,23 +112,23 @@ function basefan(widget_id, url, skin, parameters)
self.set_field(self, "icon_style", self.css.icon_style_active)

//decide which icon to mark as selected
if (state.attributes.speed == self.parameters.fields.low_speed){
if (state.attributes.percentage == self.parameters.fields.low_speed){
self.set_field(self,"speed1_style", self.css.speed1_style_active)
self.set_field(self,"speed2_style", self.css.speed2_style_inactive)
self.set_field(self,"speed3_style", self.css.speed3_style_inactive)
self.set_icon(self, "icon1", self.icons.icon1_active)
self.set_icon(self, "icon2", self.icons.icon2_inactive)
self.set_icon(self, "icon3", self.icons.icon3_inactive)
}
else if (state.attributes.speed == self.parameters.fields.medium_speed){
else if (state.attributes.percentage == self.parameters.fields.medium_speed){
self.set_field(self,"speed1_style", self.css.speed1_style_inactive)
self.set_field(self,"speed2_style", self.css.speed2_style_active)
self.set_field(self,"speed3_style", self.css.speed3_style_inactive)
self.set_icon(self, "icon1", self.icons.icon1_inactive)
self.set_icon(self, "icon2", self.icons.icon2_active)
self.set_icon(self, "icon3", self.icons.icon3_inactive)
}
else if (state.attributes.speed == self.parameters.fields.high_speed){
else if (state.attributes.percentage == self.parameters.fields.high_speed){
self.set_field(self,"speed1_style", self.css.speed1_style_inactive)
self.set_field(self,"speed2_style", self.css.speed2_style_inactive)
self.set_field(self,"speed3_style", self.css.speed3_style_active)
Expand Down
8 changes: 4 additions & 4 deletions appdaemon/widgets/fan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
widget_type: basefan
entity: "{{entity}}"
post_service_speed:
service: fan/set_speed
service: fan/set_percentage
entity_id: "{{entity}}"
post_service_active:
service: fan/turn_on
Expand All @@ -19,9 +19,9 @@ fields:
icon1: ""
icon2: ""
icon3: ""
low_speed: "low"
medium_speed: "medium"
high_speed: "high"
low_speed: 33
medium_speed: 66
high_speed: 100
icons:
icon_active: $fan_icon_on
icon_inactive: $fan_icon_off
Expand Down