Skip to content

Fix JUnit XML attribute escaping (use quoteattr) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levine-cycode merged 1 commit into from
Apr 23, 2026
Merged

Fix JUnit XML attribute escaping (use quoteattr) #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions scripts/cycode-json-to-junit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import json
import sys
from xml.sax.saxutils import escape
from xml.sax.saxutils import escape, quoteattr


def extract_detections(data):
Expand Down Expand Up @@ -61,10 +61,13 @@ def main(src: str, dst: str) -> int:
name = f"{path}:{line}" if line else path
detail = json.dumps(d, indent=2, default=str)
cdata = detail.replace("]]>", "]]]]><![CDATA[>")
out.append(f' <testcase classname="{escape(classname)}" name="{escape(name)}">')
# Use quoteattr (returns the value wrapped in quotes with ", &, <, >
# escaped). Plain escape() doesn't handle " — any finding message
# containing a double quote breaks PublishTestResults@2 parsing.
out.append(f' <testcase classname={quoteattr(classname)} name={quoteattr(name)}>')
out.append(
f' <failure type="{escape(severity)}" '
f'message="{escape(str(message))[:200]}"><![CDATA[\n{cdata}\n]]></failure>'
f' <failure type={quoteattr(severity)} '
f'message={quoteattr(str(message)[:200])}><![CDATA[\n{cdata}\n]]></failure>'
)
out.append(" </testcase>")

Expand Down
Loading