Merged
Conversation
Collaborator
|
처음에 카테고리 테이블을 id, label, value로 분류하려다가 괜히 복잡하게 만드는 것 같아서 뺐는데, 유렬님이 수정해주신 것처럼 Code 속성 추가하니 로직 처리 면에서나 의미론적으로도 좀 더 편해진 것 같습니다!! 뭔가 어색해서 답답했는데 깔끔하게 수정해 주셔서 감사합니다! 별 다른 이상 없어 보입니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경점 👍
테스트 💻
단위 테스트 및 Postman 이용한 테스트
스크린샷 🖼
SearchRequestDto에 아무 입력도 주지 않았을 때
검색 조건에 아무 것도 입력하지 않았을 때(현재 검색 기능 자체는 구현되어 있지 않으며, 입력한 dto를 그대로 반환)
무직 옵션을 주었을 때 연소득 기본값을 0으로 반환
무직, 군복무, 가구 수를 1명으로 입력했을 때
비고 ✏
궁금한 점 있으시면 편하게 질문해 주세요!