feat: wheel tilt-left/right as bindable buttons (verified on MX Ergo)#357
Open
g30r93g wants to merge 6 commits into
Open
feat: wheel tilt-left/right as bindable buttons (verified on MX Ergo)#357g30r93g wants to merge 6 commits into
g30r93g wants to merge 6 commits into
Conversation
Address code-review: the module docs mentioned wheel tilt but the CapturedInput::ButtonPressed variant doc, the agent-core watcher module doc, and the ButtonId doc still described the pre-tilt set. Also clarify that ButtonId variants are appended (TOML-stable) while ButtonId::ALL carries the physical layout order.
Greptile SummaryThis PR adds wheel tilt-left and tilt-right as bindable mouse controls. The main changes are:
Confidence Score: 5/5This looks safe to merge after small follow-ups to tilt capture edge cases.
crates/openlogi-hid/src/gesture.rs and crates/openlogi-agent-core/src/watchers/gesture.rs Important Files Changed
Reviews (1): Last reviewed commit: "docs(tilt): note wheel-tilt buttons in c..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the scroll-wheel tilt-left / tilt-right controls as first-class bindable buttons. These horizontal-tilt controls (HID++
0x1b04reprogrammable controls, CIDs0x5b/0x5d) weren't detected or configurable before; they now appear on the mouse diagram with an action picker and default to horizontal scroll.Addresses #100 (wheel tilt not detected / not configurable). That issue is filed against the M500S; this implements the general mechanism and is verified end-to-end on an MX Ergo (same standard Logitech tilt CIDs). I don't have an M500S to confirm, but the capture path and slot-name mapping are device-agnostic.
How (mirrors existing patterns)
ButtonId::TiltLeft/TiltRight(appended, TOML-stable), default-bound toHorizontalScrollLeft/HorizontalScrollRight.thumbwheel_armed), so native horizontal scrolling is untouched otherwise.SLOT_NAME_SCROLL_LEFT/SLOT_NAME_SCROLL_RIGHT— no asset-registry change.Verification
cargo fmt --check,cargo clippy --workspace -D warnings, andcargo test --workspace(417 passed, 0 failed) all green.tilt_armedgating, and the slot-name mapping.diag controlsreports0x5b/0x5dasdivertable, and a live capture session recorded 142 physical tilt events correctly mapped toTiltLeft/TiltRight(not swapped).Not in scope
0xd7).