fix: embed and sign the openlogi CLI in the macOS app bundle#362
Open
mvanhorn wants to merge 3 commits into
Open
fix: embed and sign the openlogi CLI in the macOS app bundle#362mvanhorn wants to merge 3 commits into
mvanhorn wants to merge 3 commits into
Conversation
The macOS release bundle only embedded openlogi-gui, so the openlogi CLI was missing from the .app (the Linux package and the Homebrew cask both expect it under Contents/MacOS/openlogi). Add an embed_cli step mirroring embed_agent_helper, and a verify_bundle_binaries check so a future regression fails the build.
15 tasks
Greptile SummaryThis PR embeds the macOS CLI into the app bundle and signs it for release. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "ci(release): sign the embedded CLI in th..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #328. The macOS
.appbundle now includes theopenlogiCLI binary, so it is present in the release the same way it is in the Linux package and where the Homebrew cask'sbinarystanza expects it (Contents/MacOS/openlogi).Why this matters
The macOS bundle step only embedded
openlogi-gui, so the CLI was absent from the shipped.app. Users installing the macOS release had noopenlogicommand, while Linux users did. The fix mirrors the existing agent-helper embedding so the CLI ships alongside the GUI.Changes
xtask/.../macos/bundle.rs: addembed_cli, which buildsopenlogi --releaseand copies it intoContents/MacOS/openlogi, mirroringembed_agent_helper. Addverify_bundle_binaries, called at the end ofrun(), asserting bothopenlogiandopenlogi-guiare present so a future regression fails the build loudly (unit-tested against a temp dir, no Xcode toolchain required).Contents/MacOS, so it needs its own hardened-runtime signature before the outer app or notarization rejects its as-built ad-hoc signature.sign_appnow signs (and verifies) the CLI in the same inside-out order it uses for the agent helper, and the release workflow's signing step does the same, so tagged notarized builds stay valid.Testing
cargo build -p xtask,cargo test -p xtask(5 passing, including the newverify_bundle_binariescases), andcargo clippy -p xtaskall pass. Runningxtask macos bundlelocally produces anOpenLogi.appcontaining bothopenlogiandopenlogi-gui. The codesign/notarization steps run only in the tagged release workflow (they need the signing certificate), so those were reviewed against the existing agent-helper signing pattern rather than executed here.