Remove GEE dependency (APR-180)#49
Merged
Merged
Conversation
Now that APR-179 confirmed the STAC path is live in the app: - Delete src/onkia/satellite_lst.py (GEE-based satellite module) - Delete tests/test_satellite_lst.py (tests for the old GEE module) - Move shared dataclasses, constants, and utility functions (LSTObservation, LSTHistoryPoint, NDCIObservation, LAKE_ACRES, celsius_to_fahrenheit, etc.) directly into satellite_lst_stac.py, removing the cross-module import - Update test_satellite_lst_stac.py to import those types from satellite_lst_stac - Remove earthengine-api>=0.1.370 from pyproject.toml and requirements.txt All 218 relevant tests pass. Fixes APR-180. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes APR-180. APR-179 confirmed the STAC path is live in the app; this PR removes the old GEE-based module entirely.
src/onkia/satellite_lst.py(Google Earth Engine module, 623 lines)tests/test_satellite_lst.py(GEE-specific tests, 404 lines)LSTObservation,LSTHistoryPoint,NDCIObservation,LAKE_ACRES,celsius_to_fahrenheit,kelvin_to_celsius,ndci_to_category,lake_radius_m) intosatellite_lst_stac.py, removing the cross-module importtests/test_satellite_lst_stac.pyto import those types fromsatellite_lst_stacearthengine-api>=0.1.370frompyproject.tomlandrequirements.txtTest plan
tests/test_satellite_lst_stac.py)import onkia.satellite_lstreferences (onlysatellite_lst_stac)earthengine-apioree.Initializereferences in any Python file🤖 Generated with Claude Code