Open
Conversation
…ook instead of page save complete * Fixed issues with namespaces in page titles * Cleanup
* Fixing some minor issues
…ted page contains at least one of the declared SDERelation properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Thank's for open-sourcing this extension!
This fork is a bigger rewrite of this extension and to some extend a very different approach to the problem, with different advantages and disadvantages. Feel free to to ignore this pull request or only take parts of it. This rewrite is very oppinionated. I'd be interested in your oppinion on it.
It might be an idea to merge the old and the new SDE behavior and let the user choose it through a setting.
Fixes
SDE did not work with pages having a namespace. This is fixed by using
$title->getPrefixedText()instead of$title->getText()when constructing the queries.Changes
ArticleSaveCompletehook, we decided to use theSMW::SQLStore::AfterDataUpdateCompleteSMW >= 2.3 hook. This has the advantage that the dummy edit is only triggered when data actually changes (usually in a job queue item). It also ensures that the queries for the SDE dependencies makes will always work as the data has already been stored. (We had issues with that). The disadvantage is that this behaviour cannot guarantuee an avoidance of loops. This is imho unlikely anyway and probably a sign of a modeling mistake anyway.New Features