Lazy-load yt-dlp media players in card template#34
Open
FellowTraveler wants to merge 1 commit into
Open
Conversation
This was referenced Jun 7, 2026
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
4d1de44 to
ef0d535
Compare
ef0d535 to
d80fdf1
Compare
Author
|
CI note: this PR also fixes the Claude plugin failures currently visible on ArchiveBox/ArchiveBox#1819. Those ArchiveBox checks clone/test upstream Local verification with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ArchiveBox/ArchiveBox#1819.
Moves the yt-dlp media player behavior into the yt-dlp plugin card template, where plugin-specific rendering belongs.
The card now:
hrefanddata-srcvalues so filenames with reserved characters still workAlso fixes Claude integration test behavior for public CI:
ANTHROPIC_API_KEYis absent instead of failing the PRCLAUDECODE_BINARYenv overrides are respected before hydrated binary defaultsVerification: