feat(player): add customizable swipe-up actions for now playing screen#807
Open
Nox-Wizard-py wants to merge 12 commits into
Open
feat(player): add customizable swipe-up actions for now playing screen#807Nox-Wizard-py wants to merge 12 commits into
Nox-Wizard-py wants to merge 12 commits into
Conversation
Introduces the configuration state required for the customizable player swipe-up gesture.
Adds the core navigation routing logic to BottomSheetPlayer and threads the onSwipeUp callback down through the layout hierarchy.
… layouts Implements a reusable, single-trigger swipe-up gesture modifier and securely attaches it to the metadata containers of the Default, V8, and V9 player designs.
Exposes the SwipeUpAction configuration to the user within the player appearance settings menu.
Provides the necessary display titles and enum option labels for the new swipe gesture UI.
Resolves redeclaration and conflicting declaration compiler errors by removing the duplicate enum injected at the top of the file.
…um values Fixes an `Argument type mismatch` error by explicitly typing the handleSwipeUp lambda as `() -> Unit` and updates enum cases to match the uppercase upstream definitions.
Fixes an `Unresolved reference 'detectDragGestures'` error by explicitly providing type declarations for the `change` and `dragAmount` lambda parameters in `onDrag`.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 259b9070cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a configurable swipe-up gesture for the Now Playing screen.
Users can now choose which action is triggered when swiping up from the player artwork / metadata area, allowing the gesture to be adapted to individual workflows instead of being fixed to a single behavior.
Available Actions
Changes
SwipeUpActionpreference and enum supportImplementation Notes
Testing
assembleDebugCloses #710