Skip to content

Feature: speed timinggroup property that sets fixed scrolling speed to timinggroup#85

Merged
rechn3r merged 2 commits intoArcthesia:trunkfrom
freeze-dolphin:tgspeed
Mar 6, 2026
Merged

Feature: speed timinggroup property that sets fixed scrolling speed to timinggroup#85
rechn3r merged 2 commits intoArcthesia:trunkfrom
freeze-dolphin:tgspeed

Conversation

@freeze-dolphin
Copy link
Copy Markdown
Contributor

  • fix: separate sc dropRate and the one set by user manually in events panel
  • refactor: remove useless DropRateChannel and related code
  • feat: allow dropRate to be negative
2026-01-28.00-48-55.mp4

…panel

refactor: remove useless DropRateChannel and related code
feat: allow dropRate to be negative
@0thElement
Copy link
Copy Markdown
Collaborator

Why did you remove DropRateChannel?

This will break existing SC code that relies on it.

@freeze-dolphin
Copy link
Copy Markdown
Contributor Author

freeze-dolphin commented Feb 10, 2026

Why did you remove DropRateChannel?

This will break existing SC code that relies on it.

Is this field just there to provide Settings.DropRate.Value?

@0thElement
Copy link
Copy Markdown
Collaborator

Yes, it's perfectly fine and desirable to leave the DropRateChannel there. An example use case would be custom note type that follows the regular note drop rate.

Seems good to me after the revert.

@rechn3r rechn3r merged commit da9de10 into Arcthesia:trunk Mar 6, 2026
@freeze-dolphin
Copy link
Copy Markdown
Contributor Author

freeze-dolphin commented Mar 7, 2026

I just realized that, should I put the DropRate (modified by sc) into GroupProperties.cs and rename it to SCDropRate?

and then let DropRateSerialized become DropRate inplace

image

like other tg properties controlled by lua sc

image

@freeze-dolphin
Copy link
Copy Markdown
Contributor Author

freeze-dolphin commented Mar 7, 2026

it's a simple minor refactor so i don't re-open a new pr

here is the patch file: https://github.com/freeze-dolphin/ArcCreate/commit/0219d3795f204e562909cd0e73600aa71f917f06.diff


now the dropRate is calculated by adding the one serialized in chart file and SCDropRate controlled by lua sc

image image

also remove the unnecessary cleanup logic:

image

@rechn3r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants