BattMonitor: DroneCAN batteries report and log state-of-health percentage#25926
BattMonitor: DroneCAN batteries report and log state-of-health percentage#25926tridge merged 1 commit intoArduPilot:masterfrom
Conversation
IamPete1
left a comment
There was a problem hiding this comment.
I think this looks basically OK, but we will have to merge the MAVLink change first so we can do the sub-module shuffle.
|
Note for DroneCAN we do have new messages that will be implemented eventually..... (---> looks at self <----) Here those are : https://github.com/dronecan/DSDL/pull/7/files MAVLink It doesn't include state of health since that changes quite slowly. Generally, adding fields to Battery_Status has been a nonstarter since it is already too large of a message.... (Nothing has been added in 4 years to it.) I did check that the SMART_BATTERY_INFO Doesn't Include : https://mavlink.io/en/messages/common.html#SMART_BATTERY_INFO |
|
I think this should go in |
0a6fab4 to
5f9fa04
Compare
Only DroneCAN backend implements this feature for now
5f9fa04 to
58a2274
Compare
This adds state-of-health percentage logging for DroneCAN battery backends. I've reduced the scope of this PR by removing the reporting via MAVLink.
The DroneCAN DSDL message already includes this field and the Tattu DroneCAN batteries send the value but we haven't made use of it until now.
This has been tested on real hardware (CubeOrangePlus with a Tattu battery). Below is a screenshot showing the SOH of 95%.