Reference and use new mavlink enumeration values#32504
Merged
peterbarker merged 2 commits intoArduPilot:masterfrom Mar 25, 2026
Merged
Reference and use new mavlink enumeration values#32504peterbarker merged 2 commits intoArduPilot:masterfrom
peterbarker merged 2 commits intoArduPilot:masterfrom
Conversation
peterbarker
force-pushed
the
pr/PREFLIGHT_CALIBRATION_MAGNETOMETER
branch
from
6f78d2a to
eefe4bf
Compare
Contributor
Author
|
MAVLink PR is here: ArduPilot/mavlink#492 |
IamPete1
approved these changes
Mar 22, 2026
peterbarker
force-pushed
the
pr/PREFLIGHT_CALIBRATION_MAGNETOMETER
branch
from
eefe4bf to
fdaa722
Compare
new enumeration values, fewer magic numbers
peterbarker
force-pushed
the
pr/PREFLIGHT_CALIBRATION_MAGNETOMETER
branch
from
fdaa722 to
7296dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use new enumeration values to remove some random constants from the code when handling MAV_CMD_PREFLIGHT stuff
Testing (more checks increases chance of being merged)
This is a no-compiler-output change:
Description
The mavlink changes are cherry-picked from mavlink/mavlink/master
This PR deliberately shaped to be no-compiler-output change.
We don't actually use many of the magnetometer values - we have a separate message for starting cal on specific compasses etc etc.