.github: add actionlint to lint GitHub Actions YAML#33213
Open
ES-Alexander wants to merge 3 commits into
Open
Conversation
ba5f436 to
125b113
Compare
Contributor
|
Thanks! |
125b113 to
d752839
Compare
Contributor
Author
|
I've just tied the download script to a specific commit - it didn't seem to make sense to try to get a specific version by blindly passing a parameter into a dynamically updating download script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rhysd/actionlintfor linting GitHub Actions YAMLClassification & Testing (check all that apply and add your own)
Description
@tridge mentioned adding this to RSync in the recent EU DevCall, so I took a stab at adding it to ArduPilot.
I've kept the bulk of the original Action, just moved it to ubuntu-slim, bumped the
checkoutversion, and cleaned up the comments a bit. I've also tied the download script to a commit hash, since otherwise it feels needlessly susceptible to a supply-chain attack (for reference, there is no official Action we can just "use" instead).I ran it locally and found:
./local paths are apparently not supported by GitHub's Actions glob/path handlingtest_chibioswas redundantly excluding a clang toolchain that's no longer used at allardupilot-qurt(inqurt_build.yml) not being a standard runner