Skip to content

common: document NAV_TAKEOFF param3 autopilot-nav requirement#486

Merged
peterbarker merged 1 commit intoArduPilot:masterfrom
peterbarker:pr-claude/nav-required-documentation
Mar 20, 2026
Merged

common: document NAV_TAKEOFF param3 autopilot-nav requirement#486
peterbarker merged 1 commit intoArduPilot:masterfrom
peterbarker:pr-claude/nav-required-documentation

Conversation

@peterbarker
Copy link

When param3 is zero, the vehicle must reject the command if it will not automatically manage horizontal position. Documents existing ArduPilot behaviour (ArduCopter GCS_MAVLink_Copter.cpp).

@peterbarker peterbarker force-pushed the pr-claude/nav-required-documentation branch 2 times, most recently from 196c940 to 2058f5b Compare March 3, 2026 03:11
Copy link

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, ArduPilot chose to provide this meaning param 3 and now we are trying to align - right?

What was the original reason for this change/why was it needed? That makes it easier to explain why it is something of general use that should be a shared common behaviour.

Can you create a version upstream so I can get some review?

@peterbarker
Copy link
Author

Just to be clear, ArduPilot chose to provide this meaning param 3 and now we are trying to align - right?

What was the original reason for this change/why was it needed? That makes it easier to explain why it is something of general use that should be a shared common behaviour.

Can you create a version upstream so I can get some review?

mavlink#2429

@peterbarker peterbarker force-pushed the pr-claude/nav-required-documentation branch from 2058f5b to 857f0c4 Compare March 18, 2026 06:10
@peterbarker
Copy link
Author

peterbarker commented Mar 18, 2026

I've made this identical to the current form which was just merged into mavlink/mavlink/master

@magicrub
Copy link

@meee1 note, this needs a MP update

When param3 is zero, the vehicle must reject the command if it will not
automatically manage horizontal position. Documents existing ArduPilot
behaviour (ArduCopter GCS_MAVLink_Copter.cpp).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@peterbarker peterbarker force-pushed the pr-claude/nav-required-documentation branch from 857f0c4 to 354310d Compare March 20, 2026 03:38
@peterbarker peterbarker merged commit b6eb0ad into ArduPilot:master Mar 20, 2026
12 checks passed
@peterbarker peterbarker deleted the pr-claude/nav-required-documentation branch March 24, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants