Conversation
bradley-erickson
changed the title
bradley-erickson
force-pushed
the
berickson/workshop
branch
from
43f5288 to
b5e2dac
Compare
https clone
Will flush out later. Copying notes for travel.
pmitros
reviewed
Jul 14, 2024
| command = insert(index + 1, char, doc_id) | ||
| await web_socket.send_str(json.dumps(command)) | ||
| await asyncio.sleep(float(ici)) | ||
| await asyncio.sleep(random.gauss(mu=float(ici), sigma=1)) |
Collaborator
There was a problem hiding this comment.
The sigma=1 is not good. 1 second means that this will often be negative, which with sleep, clips to zero. It will also often be quite large (a typical ICI is a fraction of a second). So the ICI will be larger than expected.
I think something like a Reyleigh, Chi, Poisson, or similar distribution might make more sense here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.