Update lightcone generators according to new naming conventions in diffhalos for galaxy weights#416
Merged
Merged
Conversation
…ventions in diffhalos for the weights: lc_data.nhalos --> lc_data.cen_weights, and lc_data.nhalos_host --> lc_data.sat_weight. Note that these are not straight search-and-replace changes, due to changes in the meaning of the variables. See PR notes for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the lightcone generators in diffsky according to the corresponding updates brought into diffhalos with ArgonneCPAC/diffhalos#39.
Now the quantity
sat_weightcan be passed directly to compute_x_tot_from_x_in_situ without any rigamarole. Also, when downstream users of weighted lightcones need to compute weighted photometry, e.g. using diffndhist.py and other similar calculations, the weights used in the histograms should begal_weight, defined as follows: