Add BOUND_PARAM_COLLECTION namedtuple#426
Merged
Merged
Conversation
aphearin
approved these changes
May 26, 2026
Collaborator
aphearin
left a comment
aphearin
left a comment
There was a problem hiding this comment.
As discussed with @nvillanova the only reason for the two failing workflows is that diffstar changes in main have not yet been included in the latest diffstar release. Let's proceed to merge while we wait for conda-forge to catch up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a new namedtuple
BOUND_PARAM_COLLECTIONin thediffsky_param_wrapper.pyanddiffsky_param_wrapper_merging.pymodules.It has the same structure as
DEFAULT_PARAM_COLLECTION, but instead of storing the default scalar values, it stores tuples containing the lower and upper bounds for each parameter.This is related to the PRs in diffstar and dsps.