Incorporate differentiable satellite quenching into all photometry kernels#429
Merged
Conversation
…_kernels. Still need to compute weighted linelum
…gorithm has changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in
gd_-versions of all the photometry kernels, e.g.,gd_dbk_kernels.py,gd_dbk_specphot_kernels_merging.py, etc. This is partial progress towards the effort began in #421 and #425 to incorporate differentiable satellite quenching into the kernels.Note that the way that the
rapid_quenchingmodule is used in this code is slightly different from what was implemented in #421 and #425. Here, we implement rapid quenching before burstiness is added, whereas before we implemented it after. This new way of doing it made it much more straightforward to incorporate rapid quenching into the disk/bulge/knot decomposition. With this new way of doing things, some additional work is needed to ensure that burstiness does not undo the effect of rapid quenching: now we additionally maplgfburst-->1e-7asp_merge-->1, whereas before this additional step was not needed. The upshot is that previously-run gradient descents were run on slightly different versions of the rapid quenching effect. I don't think this change should have any material consequences, but I thought worth flagging just in case.The new
gd_modules still exist on an island of code unto themselves, and have not yet been incorporated into the mock production. Before that, we will needgd_versions of the sed kernels, such askernels/sed_kernels_merging.pyandkernels/dbk_sed_kernels_merging.py.