Skip to content

fix(security): do not store API token in sessionStorage - #12

Merged
ArianAr merged 1 commit into
mainfrom
fix/codeql-token-storage
Jul 16, 2026
Merged

fix(security): do not store API token in sessionStorage#12
ArianAr merged 1 commit into
mainfrom
fix/codeql-token-storage

Conversation

@ArianAr

@ArianAr ArianAr commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes open CodeQL alert js/clear-text-storage-of-sensitive-data on frontend/src/App.jsx.

Root cause of PR #10 red “CodeQL” check (partial):
GitHub Advanced Security AI findings job failed with infrastructure error model_not_supported (claude-opus-4.6) — not an application bug.

Real alert: token was stored via sessionStorage.setItem. Now held only in JS memory (re-enter after full page reload).

Test

  • Frontend production build
  • go test ./...

Resolve CodeQL js/clear-text-storage-of-sensitive-data by not writing
the operator API token to sessionStorage; hold it in process memory for
the page session only.
@ArianAr ArianAr added this to the M5 — Hardening & Operations milestone Jul 16, 2026
@ArianAr ArianAr added security Security related frontend React dashboard labels Jul 16, 2026

@ArianAr ArianAr left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: correct fix for clear-text-storage; memory-only token is appropriate for shared operator secret. Approve when CI green.

@ArianAr
ArianAr enabled auto-merge (squash) July 16, 2026 18:06

@ArianAr ArianAr left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: correct fix for clear-text-storage; memory-only token is appropriate for shared operator secret. Approve when CI green.

@ArianAr
ArianAr merged commit 2672105 into main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend React dashboard security Security related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant