feat(secrets): encrypt provider secrets at rest (M5.2) - #17
Merged
Conversation
Add GANTRY_SECRETS_KEY/-secrets-key, encrypt on write, decrypt on read, and migrate legacy plaintext secrets when a key is configured (M5.2).
ArianAr
added
enhancement
ArianAr
commented
Jul 16, 2026
ArianAr
left a comment
ArianAr
left a comment
Owner
Author
There was a problem hiding this comment.
Review: AES-GCM envelope + migrate-on-open is solid; empty-key passthrough documented. Approve when CI green.
ArianAr
enabled auto-merge (squash)
July 16, 2026 18:12
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL go/weak-sensitive-data-hashing flagged single-pass SHA-256 in DeriveKey. Switch to PBKDF2-HMAC-SHA256 (210k iters) for AES key material. Also merge main into the feature branch.
Owner
Author
CodeQL fixThe red CodeQL check reported a real alert (not the AI model outage):
Fix pushed: passphrase → PBKDF2-HMAC-SHA256 (210 000 iterations, app salt) → AES-256-GCM key. Required CI checks remain Foundation/Go/Frontend/Docker; re-run should clear the CodeQL annotation once the new analysis posts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements M5.2 Secret hygiene.
Closes #15
gantry1:…) viaGANTRY_SECRETS_KEY/-secrets-keyTest
go test ./pkg/secrets ./pkg/db ./...