feat(ui): light/dark theme toggle (#28) - #45
Merged
Merged
Conversation
Add data-theme CSS variables, ThemeToggle with localStorage persistence, and FOUC-free boot script. Toggle on home, paste canvas, password gate, and not-found. Closes #28.
ArianAr
commented
Jul 15, 2026
ArianAr
left a comment
ArianAr
left a comment
Owner
Author
There was a problem hiding this comment.
Code review
Verdict: Approve
Scope: #28 only.
Strengths
- Theme tokens as RGB CSS variables keep Tailwind opacity (
/40) working - Separate light/dark ANSI palettes
- FOUC boot script +
suppressHydrationWarningon<html> - localStorage only (no tracking); defaults to dark
- Pure
themehelpers unit-tested
Minor notes
not-foundimports a client toggle (fine in App Router)- Theme is per-browser, not per-paste (as specified)
Merge when CI green.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /** Inline script: set data-theme before paint (no FOUC). */ | ||
| export const THEME_BOOT_SCRIPT = `(function(){try{var k=${JSON.stringify(THEME_STORAGE_KEY)};var t=localStorage.getItem(k);if(t!=="light"&&t!=="dark")t="dark";document.documentElement.setAttribute("data-theme",t);}catch(e){document.documentElement.setAttribute("data-theme","dark");}})();`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #28 only.
data-themelocalStorage(papercut-theme)Test plan
pnpm test(55)Closes #28