fix(security): static theme FOUC boot script (CodeQL #12) - #51
Merged
Conversation
CodeQL js/bad-code-sanitization flagged constructing THEME_BOOT_SCRIPT via JSON.stringify interpolation. Embed the storage key as a literal instead; test keeps the key and boot script in sync. Addresses code scanning alert #12.
ArianAr
added
security
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL alert #12 (
js/bad-code-sanitizationonserver/lib/theme.ts).THEME_BOOT_SCRIPTwas built with template interpolation ofJSON.stringify(THEME_STORAGE_KEY). That pattern is treated as unsafe code construction even though the value is a trusted constant.Change: fully static IIFE string with the
"papercut-theme"key literal. Unit test asserts the boot script embedsTHEME_STORAGE_KEYso they cannot drift.Test plan