feat(server): proxy-aware hops and Secure cookies - #62
Merged
Conversation
TRUSTED_PROXY_HOPS (default 1) picks the client from X-Forwarded-For from the right. Unlock cookie Secure derives from PAPERCUT_PUBLIC_URL or COOKIE_SECURE. Closes #39
ArianAr
added
enhancement
ArianAr
commented
Jul 15, 2026
ArianAr
left a comment
ArianAr
left a comment
Owner
Author
There was a problem hiding this comment.
Review
Summary: Correct spoof-resistant XFF handling (rightmost trusted hop). Cookie Secure derivation matches real reverse-proxy deploys. Tests cover defaults and edges.
Verdict: LGTM once CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements roadmap v1.3.7 / issue #39.
TRUSTED_PROXY_HOPS(default 1): rate-limit key from XFF Nth-from-right0ignores XFF (all keyslocal)SecurefromCOOKIE_SECUREorhttps://public URL (else NODE_ENV)Test plan
Closes #39