fix(security): rate-limit XFF default and key prune - #69
Merged
Conversation
ArianAr
force-pushed
the
fix/66-rate-limit-direct-deploy
branch
from
July 15, 2026 23:35
bac6a32 to
3c725da
Compare
Ignore X-Forwarded-For by default so direct deploys cannot bypass create or unlock rate limits via spoofed client IPs. Opportunistically prune and cap in-memory limiter maps. Document hops=1 for reverse-proxy setups. Closes #66
ArianAr
force-pushed
the
fix/66-rate-limit-direct-deploy
branch
from
July 15, 2026 23:43
3c725da to
b8c0d16
Compare
Owner
Author
Code review summaryReviewed rate-limit XFF default + prune/evict. Verdict: No bug-severity findings. Suggestions only (nginx docs note for hops≥1; optional fail-closed overflow) — non-blocking. Rebased onto main after #68. Waiting for CI green then merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRUSTED_PROXY_HOPSis 0 (ignore XFF) for safe direct deploys1behind a reverse proxyCloses #66
Test plan
pnpm test(122 tests)pnpm lintpnpm typecheckpnpm buildcigreen