pygatt: use handle in place of uuid#7
Open
xalexalex wants to merge 2 commits intoAritzherrero4:masterfrom
Open
pygatt: use handle in place of uuid#7xalexalex wants to merge 2 commits intoAritzherrero4:masterfrom
xalexalex wants to merge 2 commits intoAritzherrero4:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I couldn't get this to work with my own triones bulbs. After some tinkering, I discovered that the problem was that
gatttoolgot stuck when asking forcharacteristics. Unfortunately,device.char_write(UUID, [...])must callcharacteristicsto get the handle associated with the UUID in order to finally calldevice.char_write_handle(handle, [...]).This patch uses the handle (
0x0007) directly, obviating the need for the call tocharacteristicsand thus fixing the problem.I have no idea whether the handle
0x0007is constant or not. If it isn't, then the patch must be made in pygatt (usingchar-descinstead ofcharacteristicsto go from UUID to handle).The PR also includes a commit that fixes a typo.
Thanks,
Alessandro