fix: prevent double character input on Android Shift+key#65
Open
aakhter wants to merge 1 commit intoArk0N:masterfrom
Open
fix: prevent double character input on Android Shift+key#65aakhter wants to merge 1 commit intoArk0N:masterfrom
aakhter wants to merge 1 commit intoArk0N:masterfrom
Conversation
On Android tablets, pressing Shift+A produces "AA" because the input event listener re-sends characters that xterm already processed via its keydown handler. Track keydown timestamps and skip input events that fire within 50ms of a handled keydown. Only affects touch devices (listener gated by isTouchDevice()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android tablets, pressing Shift+A produces "AA" because the input event listener re-sends characters that xterm.js already processed via its keydown handler.
Fix
Track
lastKeydownHandledtimestamps on the xterm textarea. Theinputevent handler skips if a keydown was processed within 50ms, preventing the double-send while still catching Android virtual keyboard symbols (keyCode 229) that xterm misses.Only affects touch devices (listener gated by
isTouchDevice()).Test plan