Skip to content

fix: added un-included cstdint header in VM/Value/Closure.hpp#702

Merged
SuperFola merged 1 commit into
ArkScript-lang:devfrom
curloz123:fix/unincludedheader
Jul 12, 2026
Merged

fix: added un-included cstdint header in VM/Value/Closure.hpp#702
SuperFola merged 1 commit into
ArkScript-lang:devfrom
curloz123:fix/unincludedheader

Conversation

@curloz123

Copy link
Copy Markdown
Contributor

Description

So while building ark, i ran into this issue:

[ 82%] Building CXX object CMakeFiles/ArkReactor.dir/src/arkreactor/VM/Value/Dict.cpp.o
[ 84%] Building CXX object CMakeFiles/ArkReactor.dir/src/arkreactor/VM/Value/Future.cpp.o
In file included from /home/curl0z/dev/git/my-ark/src/arkreactor/VM/Value/Closure.cpp:1:
/home/curl0z/dev/git/my-ark/include/Ark/VM/Value/Closure.hpp:26:24: error: ‘uint16_t’ does not name a type
   26 |     using PageAddr_t = uint16_t;
      |                        ^~~~~~~~
/home/curl0z/dev/git/my-ark/include/Ark/VM/Value/Closure.hpp:18:1: note: ‘uint16_t’ is defined in header ‘<cstdint>; this is probably fixable by adding ‘#include <cstdint>’
   17 | #include <Ark/Utils/Platform.hpp>
  +++ |+#include <cstdint>
   18 |
/home/curl0z/dev/git/my-ark/include/Ark/VM/Value/Closure.hpp:43:44: error: ‘PageAddr_t’ has not been declared; did you mean ‘daddr_t’?
   43 |         Closure(const ClosureScope& scope, PageAddr_t pa) noexcept;
      |                                            ^~~~~~~~~~
      |                                            daddr_t

rest were same trailing issue

Fix was well very simple, just added the header in blamed file.
Closes #701

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed (on https://github.com/ArkScript-lang/website, content/docs/)
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes
  • I confirm that I am the author of this code and release it to the ArkScript project under the MPL-2.0 license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

@CLAassistant

CLAassistant commented Jul 12, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29193848299

Coverage remained the same at 94.38%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 10925
Covered Lines: 10311
Line Coverage: 94.38%
Coverage Strength: 992202.98 hits per line

💛 - Coveralls

@SuperFola

Copy link
Copy Markdown
Member

Thanks for the PR! I'll merge once the CLA check passes, the failed tests are a misconfiguration due to permissions to write to PRs, nothing to worry about.

@curloz123

Copy link
Copy Markdown
Contributor Author

oh don't mingle with all this. its literally a one line change, you can implement that yourself lol

@SuperFola SuperFola merged commit e703588 into ArkScript-lang:dev Jul 12, 2026
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing header in include/Ark/VM/Value/Closure.hpp

4 participants