Feature/docker compose#4
Open
AlcibiadesCleinias wants to merge 21 commits intoArkadyBuryakov:mainfrom
Open
Conversation
Author
|
If you accept the changes: squash commits pls, ofc |
ArkadyBuryakov
requested changes
Sep 12, 2021
| # the easiest way to create tables | ||
| # but better to use https://alembic.sqlalchemy.org/ | ||
| # so, it store migration story as well | ||
| Base.metadata.create_all(bind=engine) |
Owner
There was a problem hiding this comment.
Base.metadata.create_all() should be used only in cases when you start with new database.
If you have a database with active strategies and different version of models.py - main.py will return Error on this step and won't run.
Author
There was a problem hiding this comment.
no, it depends on if you create tables yourself with meta that differ from declared in models
|
|
||
| x-app: &general-settings | ||
| networks: | ||
| - volatabot-test-net |
Owner
There was a problem hiding this comment.
volatabot -> volatobot :)
48b2723 to
7d7f124
Compare
* fixes * rm print
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, Arkady
The PR was started from my desire to add a simple compose file, and I am deept in refactoring a bit. Thus:
.env)src, so we have different layers: layers of orchestrator (docker-compose) with docs, git/github files, useful db scripts (database) then layer with code (i.e.src/)