Conversation
Arkobat
requested changes
Jul 8, 2025
Owner
Arkobat
left a comment
Arkobat
left a comment
There was a problem hiding this comment.
I think it makes sense with a factory method, but we should probably use the IHttpClientFactory to create the client.
Owner
|
Looks good 👍 And add a unit tests that verifies we can use the |
…sure the ListProjects call works when creating the service via factory.
Contributor
Author
|
@Arkobat I added a simple unit test that just ensures it can get the list of projects, so it works with my API key. Obviously I can't run your other tests since I don't have a key in your Localazy account. |
Owner
|
That is perfect @ebrob |
Arkobat
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some use cases where an initializer isn't the best way to initialize.