Merged
Conversation
veteran29
requested changes
Mar 15, 2025
addons/HotelPvP/scripts/Game/AFM_HotelPvP/GameMode/AFM_FactoryPvPGameMode.c
Outdated
Show resolved
Hide resolved
addons/HotelPvP/scripts/Game/AFM_HotelPvP/GameMode/AFM_FactoryPvPGameMode.c
Outdated
Show resolved
Hide resolved
addons/HotelPvP/scripts/Game/AFM_HotelPvP/GameMode/AFM_FactoryPvPGameMode.c
Outdated
Show resolved
Hide resolved
addons/HotelPvP/scripts/Game/AFM_HotelPvP/GameMode/AFM_FactoryPvPGameMode.c
Outdated
Show resolved
Hide resolved
addons/HotelPvP/scripts/Game/AFM_HotelPvP/Components/AFM_SpectatorComponent.c
Outdated
Show resolved
Hide resolved
addons/HotelPvP/scripts/Game/AFM_HotelPvP/Components/AFM_SpectatorComponent.c
Outdated
Show resolved
Hide resolved
...telPvP/scripts/Game/AFM_HotelPvP/Editor/Components/Editor/AFM_CameraLimitedEditorComponent.c
Outdated
Show resolved
Hide resolved
...telPvP/scripts/Game/AFM_HotelPvP/Editor/Components/Editor/AFM_CameraLimitedEditorComponent.c
Outdated
Show resolved
Hide resolved
veteran29
approved these changes
Mar 16, 2025
...telPvP/scripts/Game/AFM_HotelPvP/Editor/Components/Editor/AFM_CameraLimitedEditorComponent.c
Show resolved
Hide resolved
| return m_CameraPrefab; | ||
| } | ||
|
|
||
| override protected void CreateCamera() |
Member
There was a problem hiding this comment.
Have you tried setting the init camera transform instead of rewriting this whole logic?
Contributor
Author
There was a problem hiding this comment.
Yep, that was my first approach but somewhere in this section the set position got lost and I have no clue on why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add HotelPvP addon alongside RHS and BAF variants