Rework to allow wine prefix selection for games#46
Rework to allow wine prefix selection for games#46sjp761 wants to merge 37 commits intoArmchairDevelopers:masterfrom
Conversation
… settings during iteration of owned games
Just curious, why would you want to do that when you can use umu? Seems like way more work. |
Just something personal I added. This fork was supposed to be just my subjective improvements before I decided I'll try to add per game prefix support. I'll remove it and keep the PR focused going forward |
You dont have to remove it, I was just curious why u use the runtime directly. Also I think it might be a good idea to split the pr, since then its easier to see what you did. So one pr for the exclusion, one for the settings, etc. Or do they depend on each other too much to split them? |
I can split exclusion into its own PR but any work towards separate wine prefixes and the JSON installation detection relies on the settings refactor. Moving it to the library allows easy access to the user-set wine prefix location when wine needs to be run and the cli/tui can access said settings as well when running a game EDIT: Reverted the SLR changes EDIT 2: Basically striped out any changes unrelated to multiple wine prefixes so this PR is a lot more focused now. Exclusion I'm keeping here because part of the refactor I did allows me to use the slug as the name of the file. |
…game settings json)
…alled path, get rid of universal game prefix map
… it at the end of install and not the beginning, also need to refresh UI when install is complete)
This is work towards per-game wine prefixes. Also added file exclusion. Tested my changes on windows as well as everything works. Will help close #44
Included work in this PR
I did not add code (yet at least) that registers games as installed if someone was on the old system so games will have to be manually located again for the app to pick them up