Skip to content

BinaryRelationEncoderDecoder.parse: never return remainings that are longer than 6 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ArneBinder wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

BinaryRelationEncoderDecoder.parse: never return remainings that are longer than 6 #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e29a93
never return remainings that are longer than 6
ArneBinder Jun 19, 2025
61a1ff3
improve comment
ArneBinder Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/pie_modules/taskmodules/pointer_network/annotation_encoder_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,11 @@ def parse(self, encoding: List[int]) -> Tuple[List[BinaryRelation], Dict[str, in
if len(encoding):
for i in encoding:
current_encoding.append(i)
# An encoding is complete when it ends with a relation_id
# or when it contains a none_id and has a length of 7
if i in relation_ids or (i == none_id and len(current_encoding) == 7):
# An encoding is complete when it ends with a relation_id or when it has
# a length of 7, encodings with length above 7 are never valid. Note that
# all incomplete encodings (the 3rd return value of this method) need to
# be processable by build_decoding_constraints!
if i in relation_ids or len(current_encoding) == 7:
# try to decode the current relation encoding
try:
valid_encoding = self.decode(encoding=current_encoding)
Expand Down
Loading