Add outbound writer thread with batching and non-blocking send; extract Connection write/flush#132
Open
ArtifactForms wants to merge 2 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
writePacket(Packet)andflushOutput()protected methods fromConnection.sendand replaced the inlined write/flush calls with delegations to those methods inConnection.ServerConnectionto use a non-blocking outbound queue (LinkedBlockingQueue<Packet>) and a dedicated writer thread that polls the queue, batches up toMAX_OUTBOUND_BATCH_SIZEpackets, and writes them viawriteBatch.writeLoopthat polls with a timeout (WRITER_POLL_TIMEOUT_MS) to allow graceful shutdown and drains available packets into batches for efficient network writes.send(Packet)inServerConnectionto enqueue outbound packets instead of performing synchronous I/O, and updatedclose()to interrupt the writer thread and unregister the connection from thePlayerManager.Testing
Codex Task