Add ClientWorldOrigin and automatic floating-origin shift in ChunkManager#134
Open
ArtifactForms wants to merge 1 commit intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ClientWorldOriginclass that stores an origin chunk, converts between absolute and local world coordinates, and exposesisOutsideShiftThresholdto detect when to rebase.ClientWorld.origininstance and exposes it viaClientWorld.getOrigin().ChunkManager: the manager now retrieves the origin from the world, checksisOutsideShiftThresholdeach update, and callssetOriginChunkwhen the player moves past a configurable threshold; also addsoriginShiftThresholdChunkswith getter/setter and a default constant.GameClient.getWorldOrigin()to allow other systems to query local/absolute transforms.Testing
./gradlew build, and the build completed successfully../gradlew test, and the existing test suite completed without failures.Codex Task