rust: bump uuid to 1.23 and switch to using a workspace#568
Draft
davide125 wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Davide Cavalca <dcavalca@fedoraproject.org>
davide125
requested review from
WhatAmISupposedToPutHere and
jannau
as code owners
Apparently we're supposed to use a workspace for path-based dependencies that are in-tree, otherwise cargo can get confused. Signed-off-by: Davide Cavalca <dcavalca@fedoraproject.org>
Signed-off-by: Davide Cavalca <dcavalca@fedoraproject.org>
davide125
changed the title
Signed-off-by: Davide Cavalca <dcavalca@fedoraproject.org>
Contributor
|
I can confirm this fixes the build for me when using nixpkgs tooling, which currently fails like this on nixpkgs commit: flokli/nixpkgs@89b9af1 |
jannau
requested changes
May 30, 2026
| [dependencies] | ||
| fatfs = { path = "vendor/rust-fatfs", default-features = false, features = ["lfn", "alloc"], optional = true } | ||
| uuid = { version = "1.7.0", default-features = false, optional = true } | ||
| fatfs = { workspace = true, optional = true } |
Member
There was a problem hiding this comment.
keep default-features = false, features = ["lfn", "alloc"] I assume drooping those is responsible for large number of added dependencies in rust/Cargo.lock. This should result in a broken 1st stage / chainload enabled m1n1
Member
Author
There was a problem hiding this comment.
It's actually there down below, and adding it back here doesn't seem to make a difference. Agree that in the current form this isn't something we can ship. I'm going to let this sit for now and factor out the uuid bump in a separate PR so we can get that one merged at least.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump to what's shipped in Fedora