WIP: tools/audio_adt2dt: Parse ADT and produce per device sound nodes#612
Draft
jannau wants to merge 2 commits into
Draft
WIP: tools/audio_adt2dt: Parse ADT and produce per device sound nodes#612jannau wants to merge 2 commits into
jannau wants to merge 2 commits into
Conversation
Will be used by audio_adt2dt.py. Signed-off-by: Janne Grunau <j@jannau.net>
Parses audio speaker and headset amplifier nodes and produce the device specific DT nodes. Signed-off-by: Janne Grunau <j@jannau.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses audio speaker and headset amplifier nodes and produce the device
specific DT nodes.
This currently only handles 14/16 inch Macbook Pros since this doesn't reproduce the current config for j314, j316, j414 or j416. I'm not sure if this is caused by broken ADT, missing understanding of how the ADT maps to the DT on my part or if our DT are broken.
The first issue is that V-sense and I-sense slots are swapped. This is not an issue since speakersafetyd only uses their product but still unexpected.
The second issue is that the second woofer and tweeter on each side are to my interpretation of the ADT exchanged. The order based on
speaker$Nandrx-slotinspeaker-configin the primaryaudio-speakernode appears to be "Left Woofer 1", "Left Woofer 2", "Left Tweeter" instead of "Left Woofer 1", "Left Tweeter", "Left Woofer 2" as in the DT. This also affects the V-sense and I-sense slots.