Skip to content

muvm: Add a --passt-args argument to pass args to passt#224

Merged
slp merged 1 commit into
AsahiLinux:mainfrom
valpackett:val/zznpqktovxtl
May 8, 2026
Merged

muvm: Add a --passt-args argument to pass args to passt#224
slp merged 1 commit into
AsahiLinux:mainfrom
valpackett:val/zznpqktovxtl

Conversation

@valpackett
Copy link
Copy Markdown
Contributor

Sometimes it's necessary to pass additional args (such as the network interface) to passt. It's already been possible to spawn passt externally and give muvm its socket, but that's inconvenient especially when one wants to keep using the nicer muvm syntax for the exposed ports.

Comment thread crates/muvm/src/cli_options.rs Outdated
Comment thread crates/muvm/src/net.rs Outdated
Comment thread crates/muvm/src/cli_options.rs Outdated
Comment thread crates/muvm/Cargo.toml Outdated
@WhatAmISupposedToPutHere
Copy link
Copy Markdown
Member

Thinking of it, how bad would it be to instead do args "compiler driver"-style, so everything preceded by, say, -P gets sent to passt, and we do not do any shell expansion of our own? Eg: -P --tcp-ports -P 22

@teohhanhui
Copy link
Copy Markdown
Collaborator

I think that would only make sense if we expect that passing passt-args would be a common usage?

@WhatAmISupposedToPutHere
Copy link
Copy Markdown
Member

I think that would only make sense if we expect that passing passt-args would be a common usage?

Opposite, actually, this simplifies word splitting and does not need pulling in an extra crate in exchange for a slightly less convenient syntax

@teohhanhui
Copy link
Copy Markdown
Collaborator

IMO short names are a very limited resource.

@valpackett
Copy link
Copy Markdown
Contributor Author

Well we coooould do that style with a long arg, I guess xD

@valpackett valpackett force-pushed the val/zznpqktovxtl branch 3 times, most recently from e2cbcd8 to 5566c15 Compare May 7, 2026 21:42
Comment thread crates/muvm/src/cli_options.rs Outdated
Comment thread crates/muvm/src/cli_options.rs Outdated
Sometimes it's necessary to pass additional args (such as the network
interface) to passt. It's already been possible to spawn passt externally
and give muvm its socket, but that's inconvenient especially when one
wants to keep using the nicer muvm syntax for the exposed ports.

Signed-off-by: Val Packett <val@invisiblethingslab.com>
@slp slp merged commit e5d2167 into AsahiLinux:main May 8, 2026
2 checks passed
@valpackett valpackett deleted the val/zznpqktovxtl branch May 9, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants