muvm-guest: pwbridge: fix eventfd resource order#225
Merged
Conversation
valpackett
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
WhatAmISupposedToPutHere
approved these changes
May 8, 2026
teohhanhui
approved these changes
May 8, 2026
While the *direction* depends on which fd index is mentioned in the writefd field and which in the readfd one, the *order* of the fds must actually be preserved 1:1, because otherwise the indices seen by the guest client code would not match! Signed-off-by: Val Packett <val@invisiblethingslab.com>
valpackett
force-pushed
the
val/prvqpmpzlpsk
branch
from
6aa4395 to
c1a7067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the direction depends on which fd index is mentioned in the writefd field and which in the readfd one, the order of the fds must actually be preserved 1:1, because otherwise the indices seen by the guest client code would not match!
Oof, I did not get it right in #204 and then I was wondering why it's broken on arm… 🤦♀️ I'll need to retest on x86-64 again but now it makes sense.