Skip to content

Conversation

@0oshowero0
Copy link
Collaborator

@0oshowero0 0oshowero0 commented Jan 26, 2026

  1. Optimize pyproject.toml, add build, test, yuanrong as optional dependencies.
  2. Fix missing pre-commit checks due to the change of folder structure.
  3. Separate pytest and build test in CI, simplifies the dependency installation.

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Copilot AI review requested due to automatic review settings January 26, 2026 09:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the project configuration and CI workflows by consolidating dependency management and streamlining build processes.

Changes:

  • Enables mypy type checking globally by setting ignore_errors = false and removes module-specific overrides
  • Reorganizes optional dependencies in pyproject.toml into separate groups (build, test, yuanrong)
  • Refactors CI workflows to use pip editable installs with optional dependencies instead of explicit package lists

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
pyproject.toml Enables strict mypy type checking globally, adds structured optional dependencies for build/test/yuanrong, and removes outdated module overrides
.github/workflows/sanity.yml Removes unnecessary dependency installation steps since sanity checks only use standard library
.github/workflows/python-package.yml Switches from wheel build + install to editable install with optional dependencies, adds separate test build step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
@0oshowero0 0oshowero0 changed the title [chore] Optimize pyproject and CI script [WIP][chore] Optimize pyproject and CI script Jan 26, 2026
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: tianyi-ge <tianyig@outlook.com>
1. set -> list
2. controller info is required

Signed-off-by: tianyi-ge <tianyig@outlook.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

transfer_queue/storage/clients/yuanrong_client.py:119

class YuanrongStorageClient(TransferQueueStorageKVClient):

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

transfer_queue/storage/clients/yuanrong_client.py:119

class YuanrongStorageClient(TransferQueueStorageKVClient):

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
@0oshowero0 0oshowero0 changed the title [WIP][chore] Optimize pyproject and CI script [chore] Optimize pyproject and CI script Jan 27, 2026
@0oshowero0 0oshowero0 merged commit da2ad54 into Ascend:main Jan 27, 2026
4 checks passed
@0oshowero0 0oshowero0 deleted the fix_dependency branch January 27, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants