[Fix] Fix the bug related to the compatibility with openyuanrong_datasystem interface. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interface Signed-off-by: Evelynn-V <liwenlin0223l@gmail.com>
Evelynn-V
force-pushed
the
fix_ds_zcopy
branch
from
5f7169d to
a06eb6c
Compare
Contributor
|
I have some review comments posted on gitcode https://gitcode.com/Ascend/TransferQueue/pull/18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing details
Modified the interface parameters of
mcreateandget_buffersin theYuanrongStorageClientconnection.The return value of the interface corresponding to the openyuanrong_datasystem does not need to include the
status. Therefore, when calling the corresponding function in TransferQueue, the return value also needs to be adjusted.The waiting time for the
get_buffersoperation has been modified.If the data does not exist, do not wait. If the data exists, then proceed with the normal retrieval.The meaning of the
timeout_msparameter inget_buffersis the waiting time for subscription, that is, how long to wait if the data does not exist. If the data already exists, it will be retrieved normally and is not affected by this parameter.However, in TransferQueue, the data retrieved by
get_buffersshould definitely exist, it has nothing to do with thetimeout_msparameter. Even if the data is not immediately retrieved, as long as it is known to exist, it will definitely be retrieved no matter how long it takes.