Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps like LiveSplit have this functionality, where you sum all of your best splits and combine them into the "theoretically" best possible time. I added something similar here.
I had to rewrite the timer code quite a bit for this to work, since the old timer did not account for start -> M/B1-1, M3-3 -> finale and B1/2/3-3 -> main route transition times. I tried to make changes as little as possible, and, personally, did not see any breakage.
I also register the /showadvancedpath command through the recommended fabric way of hooking into ClientCommandRegistrationCallback, and not through packets, just cus I find it easier.
Here's the screenshot of how it looks:
